Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1177

wants to merge 3 commits into from

Conversation

ziriael-absten
Copy link

No description provided.

app/main.py Outdated
Comment on lines 17 to 21
counter = 0
for i in phrase:
if i.lower() == letter.lower():
counter += 1
return counter

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to implement it in one line

app/main.py Outdated
@@ -14,4 +14,4 @@ def count_occurrences(phrase: str, letter: str) -> int:
:param letter: letter to find occurrences of it
:return: count occurrences of letter in phrase
"""
# write your code here
return sum(1 for i in phrase if i.lower() == letter.lower())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use method count of string instead of sum

Copy link

@EdAlekseiev EdAlekseiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants